Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix folder listing template when plone.eventlocation behavior is disabled #680

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

petschki
Copy link
Member

fixes #679

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@jensens
Copy link
Member

jensens commented Feb 19, 2024

@jenkins-plone-org please run jobs

@petschki
Copy link
Member Author

petschki commented Mar 5, 2024

@jenkins-plone-org please run jobs

Copy link
Contributor

@MrTango MrTango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jensens jensens merged commit 8973038 into master Mar 5, 2024
13 checks passed
@jensens jensens deleted the fix-679 branch March 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Folder listing template breaks when IEvent types do not have enabled plone.eventlocation behavior
4 participants