Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #1743

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Fix broken links #1743

merged 5 commits into from
Oct 25, 2024

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Oct 25, 2024


📚 Documentation preview 📚: https://plone6--1743.org.readthedocs.build/

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevepiercy I just changed this in #1741 to fix a linkcheck error. Is it redirecting inconsistently?

@stevepiercy
Copy link
Contributor Author

The advice in linkcheck was wrong, as it only detects the response from the server. I manually researched the new link based on the existing link.

It could be argued that the better link would be to the root of the site instead of how to install it. We actually need to improve this Glossary entry, now that I think about it. Update coming.

@davisagli
Copy link
Member

@stevepiercy Oh I see, I used the new redirect but it didn't go to the same content as before. Mea culpa.

@stevepiercy
Copy link
Contributor Author

@davisagli I think we're good now. One more review?

@davisagli davisagli merged commit 2c1c73b into 6.0 Oct 25, 2024
3 checks passed
@davisagli davisagli deleted the linkcheck-2024-10-25 branch October 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants