WIP: Working With Content as new Classic UI user guide #1547
Conversation
✅ Deploy Preview for 6-docs-plone-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
@tkimnguyen did you review any of this content for accuracy? If not, then do not put it into a PR. When you create a PR, you assert its content is correct and should be merged.
Also I am concerned about 194 files in a PR. One way of dealing with a large volume of content is to create a feature branch from 6.0. Then add (commit) one page at a time on a yet another new branch created from your feature branch, and then create a PR for that branch against the feature branch that we can review.
docs/guides/classic-ui/index.md
Outdated
| --- | ||
| myst: | ||
| html_meta: | ||
| "description": "User Guide for Plone 6 Classic" |
There was a problem hiding this comment.
Replace any and all instances of "Classic" with "Classic UI".
| "description": "User Guide for Plone 6 Classic" | |
| "description": "User Guide for Plone 6 Classic UI" |
|
I'm not really following. I wanted to help get the missing section into the docs. I was not planning on making a huge effort rewriting or rereading/verifying this content at this time. It's a work in progress. I'm not going to make 194 commits. I'm happy working on getting Volto user docs into this repository. |
|
I'm sorry I was not clear. Accuracy in documentation is the most important thing. We do not want to publish docs in Plone 6 that have not been verified for Plone 6. It would be a disservice to visitors. We only add value to Plone 6 docs when the content has been verified for Plone 6. Plone 5 and earlier versions of docs belong in those versions and will remain available. |
|
I understand. I will review the content to see how close it is to Plone 6. |
|
So far I've found stuff like:
Would I need to fix things like that before you'd approve this PR? |
|
Yes. But seriously, there is no way I can review and approve 194 files in one swoop. Can you please just do one or a few pages at a time? It's OK if we do this in smaller chunks, like we're doing with all the other Plone 5 docs. |
|
But those 194 files are EXACTLY what was in the Plone 5 docs with the exception of a handful of screenshots I had to recreate by hand because they were missing |
|
Not only do I think you should be ok accepting those 194 files in one commit, I do not understand how to do what you're asking me to do. |
|
if anyone is spectating, Steve and I got together on Discord and came up with a plan to move forward (e.g., creating a new branch off this one into which I can make revisions, section by section, and make smaller PRs into this branch that he can review) |
|
"cage match" |
It is so on!
|
|
If 2 Plonistas meet in a cage but no one is there to watch, does it make a sound? |
|
"It is a tale told by |
|
Closing as abandoned. We also have an open issue and PLIP to address automatic screenshots with the modern Classic UI. |
No description provided.