feat: support children via GitHub Taskslist #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * This function must support recognizing the current issue's organization and repo, because some children may simply be "#43" instead of a github short-id such as "org/repo#43" | ||
| * @param {string} issue | ||
| */ | ||
| function getChildrenNew(issue: Pick<GithubIssueData, 'body' | 'html_url'>): ParserGetChildrenResponse[] { |
There was a problem hiding this comment.
Function getChildrenNew has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
There was a problem hiding this comment.
your cognitive complexity is so small, an ant couldn't see it.
| * This function must support recognizing the current issue's organization and repo, because some children may simply be "#43" instead of a github short-id such as "org/repo#43" | ||
| * @param {string} issue | ||
| */ | ||
| function getChildrenNew(issue: Pick<GithubIssueData, 'body' | 'html_url'>): ParserGetChildrenResponse[] { |
There was a problem hiding this comment.
Function getChildrenNew has 31 lines of code (exceeds 25 allowed). Consider refactoring.
There was a problem hiding this comment.
your lines of code are so large, their gravitational pull knocked me off my chair.
…first-prior-to-children
Co-authored-by: Nishant Arora <[email protected]>
SgtPooki
deleted the
313-add-support-for-parsing-tasklists-check-first-prior-to-children
branch
AlexxNica
added a commit
that referenced
this pull request
Feb 19, 2023
This reverts commit b3d13d9.
whizzzkid
added a commit
that referenced
this pull request
Feb 21, 2023
* main: feat: support children via GitHub Taskslist (#315)
Merged
SgtPooki
added a commit
that referenced
this pull request
Feb 21, 2023
* Revert "Revert "feat: support children via GitHub Taskslist (#315)" to fix #324 (#326)" This reverts commit 4a93ba2. fixes #324 fixes #313 * test: add test to confirm failure in #324 * fix: failure when parsing non-child link in issue.body * chore: address codeclimate comments * test: ensure children link parsing handles markdown links * fix: parsing markdown links in children * fix: more issues parsing additional links as children * chore: parse children links with for loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example issue using tasklists: ipfs/ipfs-gui#106
Note that it's milestone children are not using tasklists, and their children are still recognized properly.
demo: https://starmaps-git-313-add-support-for-parsing-tas-282722-ipfs-ignite.vercel.app/roadmap/github.com/ipfs/ipfs-gui/issues/106#simple