FIX replace 20.04->22.04 in repo URLs #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukablan-wpc
force-pushed
the
ukablan_fix__c2alma_fail_since_version_in_repo_url__PAUX-6369
branch
from
7c1f301
to
8f76f58
Compare
SandakovMM
reviewed
Oct 2, 2024
| @@ -112,6 +112,10 @@ def construct_actions( | |||
| # we support following PHP versions: PHP 7.1, 7.2, 7.3. | |||
| actions.UpdateLegacyPhpRepositories(self._distro_from, self._distro_to), | |||
| actions.SetupUbuntuRepositories("focal", "jammy"), | |||
| actions.ReplaceAptReposRegexp( | |||
| r'(http|https)://([^/]+)/(.*\b)20\.04(\b.*)', | |||
There was a problem hiding this comment.
This looks scary 😆
But ok, let's try this approach
There was a problem hiding this comment.
For me replacing strings naively is more scary :)
I expect, at most no-op (transform the string as is) when it could harm.
SandakovMM
approved these changes
Oct 2, 2024
ukablan-wpc
deleted the
ukablan_fix__c2alma_fail_since_version_in_repo_url__PAUX-6369
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use regular expressions (
actions.ReplaceAptReposRegexp) to do it.