Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcj/223474 - cookie bar #50

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Dcj/223474 - cookie bar #50

wants to merge 27 commits into from

Conversation

sene-plenty
Copy link
Contributor

No description provided.

@sene-plenty sene-plenty requested a review from a team January 26, 2022 15:17
Copy link
Contributor

@pfrincu-plenty pfrincu-plenty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the proper name of the pull request

src/partials/cookie-further-settings.hbs Outdated Show resolved Hide resolved
@sene-plenty sene-plenty changed the title Dcj/223474 Dcj/223474 - cookie bar Feb 1, 2022
Copy link
Collaborator

@ksted ksted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2022-03-02 at 13 17 32

The alignment of the tables across boxes is a bit off here. I'm pretty sure this is my fault, but I'm blind and can't find the problem in the code. Do you see the cause of this by any chance?

src/js/13-cookies.js Outdated Show resolved Hide resolved
src/lang/de-de.json Outdated Show resolved Hide resolved
src/lang/en-gb.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants