Skip to content

Commit

Permalink
Merge pull request #123 from plentymarkets/fix/displayname_default
Browse files Browse the repository at this point in the history
fix bug, where empty displayname translation fails
  • Loading branch information
felixgehrmann authored May 11, 2021
2 parents 44ee39e + 6e61cee commit 4c7316f
Show file tree
Hide file tree
Showing 14 changed files with 32 additions and 12 deletions.
10 changes: 10 additions & 0 deletions meta/documents/changelog_de.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Release Notes für Feedback

## v4.0.3 (2021-05-10)

### TODO

- Nach dem Update auf Version 4.0.3 müssen Widgets im Menü **CMS » ShopBuilder** durch Klick auf **Inhalte neu generieren** aktualisiert werden.

### Behoben

- Feedbacks ohne Autorennamen haben zu einem Fehler geführt. Dies wurde behoben.

## v4.0.2 (2021-05-05)

### TODO
Expand Down
10 changes: 10 additions & 0 deletions meta/documents/changelog_en.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Release Notes for Feedback

## v4.0.3 (2021-05-10)

### TODO

- After updating the feedback plugin to v4.0.3, it is necessary to re-generate ShopBuilder widgets via the **Regenerate contents** button in the **CMS » ShopBuilder** menu.

### Behoben

- Feedbacks submitted without an author's name led to an error. This has been fixed.

## v4.0.2 (2021-05-05)

### TODO
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "plentymarkets-feedback",
"license": "AGPL-3.0",
"version": "4.0.2",
"version": "4.0.3",
"repository": {
"type": "git",
"url": "https://github.com/plentymarkets/feedback-plugin.git"
Expand Down
2 changes: 1 addition & 1 deletion plugin.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"version": "4.0.2",
"version": "4.0.3",
"name": "Feedback",
"marketplaceName": {
"de": "Kunden-Feedback",
Expand Down
2 changes: 1 addition & 1 deletion resources/js/dist/chunks/feedback-2.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion resources/js/dist/chunks/feedback-2.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/chunks/feedback-3.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/chunks/feedback-3.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/feedback-server.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion resources/js/dist/feedback-server.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/feedback-server.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/js/dist/feedback-server.min.js.map

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ export default {
})
.join('')
} else {
return $translate('Feedback::Feedback.guestName')
return this.$translate('Feedback::Feedback.guestName')
}
},
Expand Down

0 comments on commit 4c7316f

Please sign in to comment.