Fix for asset pipeline (GPSHIRO-79) and Grails 2.4.4 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found one more (duplicate) issue https://jira.grails.org/browse/GPSHIRO-82 |
|
Upgraded to Apache Shiro 1.2.3 and made sure the plugin works with Grails 2.4.4 |
goeh
changed the title
|
Thanks for that, I'll try and manually merge those into the shiro2 plugin and make sure they are ported to the shiro 3 plugin. I've been manually doing that myself :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the shiro-quick-start script the template for SecurityFilters.groovy does not work well with the asset pipeline plugin. All assets (images, css) are protected by shiro and you see broken images and no styles, unless you are logged in.
Adding a check for 'asset' controller fixes it.
You could arge that protecting assets are a feature that should be active by default but I think it causes more confusion than help for beginners. See https://jira.grails.org/browse/GPSHIRO-79