Replace hardcoded upper boundaries with maxResetReleaseTimerDays

pleasew8t · Jun 18, 2024 · b8d2c6e · b8d2c6e
1 parent 6b05bff
commit b8d2c6e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/node/pkg/adminrpc/adminserver.go b/node/pkg/adminrpc/adminserver.go
@@ -1034,7 +1034,7 @@ func (s *nodePrivilegedService) ChainGovernorResetReleaseTimer(ctx context.Conte
 	}
 
 	if req.NumDays < 1 || req.NumDays > maxResetReleaseTimerDays {
-		return nil, fmt.Errorf("the specified number of days falls outside the range of 1 to 7")
+		return nil, fmt.Errorf("the specified number of days falls outside the range of 1 to %d", maxResetReleaseTimerDays)
 	}
 
 	resp, err := s.governor.ResetReleaseTimer(req.VaaId, req.NumDays)

diff --git a/node/pkg/adminrpc/adminserver_test.go b/node/pkg/adminrpc/adminserver_test.go
@@ -367,19 +367,24 @@ func TestChainGovernorResetReleaseTimer(t *testing.T) {
 		},
 		"NumDaysEqualsUpperBoundary": {
 			vaaId:          "valid",
-			numDays:        7,
+			numDays:        maxResetReleaseTimerDays,
 			expectedResult: success,
 		},
 		"NumDaysExceedsUpperBoundary": {
 			vaaId:          "valid",
-			numDays:        8,
+			numDays:        maxResetReleaseTimerDays + 1,
 			expectedResult: boundsCheckFailure,
 		},
 		"EmptyVaaIdAndNumDaysExceedsUpperBoundary": {
 			vaaId:          "",
-			numDays:        1000,
+			numDays:        maxResetReleaseTimerDays + 1,
 			expectedResult: vaaIdLengthFailure,
 		},
+		"NumDaysSignificantlyExceedsUpperBoundary": {
+			vaaId:          "valid",
+			numDays:        maxResetReleaseTimerDays + 1000,
+			expectedResult: boundsCheckFailure,
+		},
 	}
 
 	ctx := context.Background()