Add missed assertions to the 'missing-playwright-await' rule #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rule: add new noElementHandle rule * chore: move end range to const * fix: getRange method for non-awaiting statements * test: add additional tests for the noElementHandle rule * chore: improve noElementHandle rule * docs: update the wording of noElementHandle rule * rule: update message to match with other rule naming conventions * rule: change noElementHandle to warn level * rule: noElementHandle change fixable to suggestion * test: add valid tests for noElementHandle rule * rule: change type for noElementHandle to suggestion * rule: update noElementHandle rule's message for suggestions * rule: update noElementHandle with getRange method * rule: add new noEval rule * utils: add ast helpers * chore: add newline at end of file * chore: change double quote to single * chore: add link for the noEval rule * utils: add isCalleeProperty function
* rule: add new noElementHandle rule * chore: move end range to const * fix: getRange method for non-awaiting statements * test: add additional tests for the noElementHandle rule * chore: improve noElementHandle rule * docs: update the wording of noElementHandle rule * rule: update message to match with other rule naming conventions * rule: change noElementHandle to warn level * rule: noElementHandle change fixable to suggestion * test: add valid tests for noElementHandle rule * rule: change type for noElementHandle to suggestion * rule: update noElementHandle rule's message for suggestions * rule: update noElementHandle with getRange method * feat: add new noFocusedTest rule * chore: remove unneeded function in test. change DS for isTestGroup function * chore: remove valid function
* rule: add new noElementHandle rule * chore: move end range to const * fix: getRange method for non-awaiting statements * test: add additional tests for the noElementHandle rule * chore: improve noElementHandle rule * docs: update the wording of noElementHandle rule * rule: update message to match with other rule naming conventions * rule: change noElementHandle to warn level * rule: noElementHandle change fixable to suggestion * test: add valid tests for noElementHandle rule * rule: change type for noElementHandle to suggestion * rule: update noElementHandle rule's message for suggestions * rule: update noElementHandle with getRange method * feature: add noWaitForTimeout rule
* rule: add new noElementHandle rule * chore: move end range to const * fix: getRange method for non-awaiting statements * test: add additional tests for the noElementHandle rule * chore: improve noElementHandle rule * docs: update the wording of noElementHandle rule * rule: update message to match with other rule naming conventions * rule: change noElementHandle to warn level * rule: noElementHandle change fixable to suggestion * test: add valid tests for noElementHandle rule * rule: change type for noElementHandle to suggestion * rule: update noElementHandle rule's message for suggestions * rule: update noElementHandle with getRange method * feat: add noSkippedTest rule * chore: add missed import * docs: add missed in example * chore: add 'only' annotation in valid test
|
Thanks! |
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just appended missed assertions to the playwright matchers.