Skip connection for datasources with omitted db configuration #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent issue #402 by skipping the creation and registration of a
DatabaseConfig
for ebean datasources which have no db connection parameters configured.With this PR, users are able to specify and enhance Ebean models for datasources that may not be available on application startup, or that may be connected at a later stage during runtime. The
ebean.<datasource>
configuration can be specified without the need to also specifydb.<datasource>
.After a few tests, this seems to behave as I'd expect.
DataSource user is null?
exceptionI added a Logger to print information about the server config being skipped. I was not able to find a reference on how this should be done, so I did it the same way I'd do it in a Play application, by using
play.Logger.ALogger
. Let me know if this needs change.