VR fixes

playcanvas · Nov 21, 2024 · a58c588 · a58c588
1 parent 636d3df
commit a58c588
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/examples/positional-sound.html b/examples/positional-sound.html
@@ -30,6 +30,9 @@
                 <pc-entity name="camera" position="0 1 7">
                     <pc-camera clear-color="#8099e6"></pc-camera>
                     <pc-listener></pc-listener>
+                    <pc-scripts>
+                        <pc-script name="vr"></pc-script>
+                    </pc-scripts>
                 </pc-entity>
                 <!-- Light -->
                 <pc-entity name="light" rotation="45 0 0">

diff --git a/examples/scripts/vr.mjs b/examples/scripts/vr.mjs
@@ -93,9 +93,9 @@ export default class Vr extends Script {
         });
 
         this.app.xr.input.on('remove', (inputSource) => {
-            const entity = this.controllers.get(inputSource);
-            if (entity) {
-                entity.destroy();
+            const controller = this.controllers.get(inputSource);
+            if (controller) {
+                controller.entity.destroy();
                 this.controllers.delete(inputSource);
             }
         });

diff --git a/examples/splat.html b/examples/splat.html
@@ -41,8 +41,8 @@
                                 "zoomMax": 3
                             }'
                         ></pc-script>
+                        <pc-script name="vr"></pc-script>
                     </pc-scripts>
-                    <pc-script name="vr"></pc-script>
                 </pc-entity>
                 <!-- Statue -->
                 <pc-entity name="statue" position="0 1 0" rotation="0 45 0">