-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds React Export Option #335
Open
marklundin
wants to merge
12
commits into
main
Choose a base branch
from
feat-react-export
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can we maybe cull some unecessary files such as |
… in splat-serialize.ts to use global JSZip reference.
You still need to cull |
removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Export
This PR adds an option for exporting a React app using the
@playcanvas/react
library.The export generates a project zip file that contains all the necessary assets and dependencies. Once downloaded you can run
npm install && npm run dev
to run the project. The zip is a Vite project so it works with live reload etc.Implementation
The project template is stored in
/src/templates/react
. At build time, this is compiled to a template zip storeddist/static/templates/react.zip
. When a user exports their splat at runtime, this template zip is loaded, the.ply
is injected into to the zip, the necessary variables are added to the.env
file and the subsequent zip is downloaded.Currently, the zip export is in the
Scene -> Export -> React App
menu