Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer export options #333

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Viewer export options #333

merged 4 commits into from
Dec 12, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Dec 12, 2024

This PR:

  • adds a popup dialog for viewer export options
  • populates the settings with editor settings the first time it's shown
  • adds support for generating a .zip package instead of single-file html
  • shows a filename field when running in safari (which doesn't support file picker)

Screenshot 2024-12-12 at 13 37 33

Notes:

  • I haven't managed to include JSZip correctly the usual way, so it's being raw-dog loaded in the application's index.html
  • the structure of settings etc is messy and needs a cleanup
  • eventually the new viewer export dialog should form the basis of a reusable settings dialog, including scss

@slimbuck slimbuck added the enhancement New feature label Dec 12, 2024
@slimbuck slimbuck requested a review from a team December 12, 2024 14:05
@slimbuck slimbuck self-assigned this Dec 12, 2024
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait to play with this!! 👀

@slimbuck slimbuck merged commit 90d1758 into playcanvas:main Dec 12, 2024
2 checks passed
@slimbuck slimbuck deleted the export-dialog branch December 12, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants