Reorganization of the selection-classes #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest you submit the lasso tool implementation separately from an attempt to rearchitecting the code. |
simonbethke
changed the title
|
After adding the lasso-tool, i started extracting a base-class for all selection-tools. The simple lasso-selection now is handled here: |
|
Not planning on this reorg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just re-added the simple lasso-selection. I will keep this as draft right now as I need to extract a base-class for different selection-types. For doing that I also have to make actual typescript classes from that without defining all methods as local variables in the closure.