Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tag exported ply files #211

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

simonbethke
Copy link
Contributor

Similar to Nerfstudio, where I requested nerfstudio-project/nerfstudio#3472 to write the term "nerfstudio" into the header, also super-splat should always do that.

src/splat-convert.ts Outdated Show resolved Hide resolved
@willeastcott
Copy link
Contributor

Add SuperSplat version number?

@simonbethke
Copy link
Contributor Author

Yes, I was only choosing this string as it is used at another place this way. I'll clean it up

Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3<3

src/splat-convert.ts Outdated Show resolved Hide resolved
@willeastcott willeastcott merged commit 09d7eaf into playcanvas:main Oct 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants