Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support camera poses #198

Merged
merged 20 commits into from
Oct 2, 2024
Merged

Support camera poses #198

merged 20 commits into from
Oct 2, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Oct 2, 2024

Fixes: #186

ss-camera-poses.mov

This PR includes the following changes:

  • add the ability to load colmap cameras.json format camera poses
  • displays the list of poses in a list on the view options panel
    • the list will likely be moved to its own popup window
  • supports switching between camera poses and playing back the poses as an animation
  • update input handling for popup windowsb
  • update npm dependencies except eslint
  • fix spotty grid rendering

@slimbuck slimbuck added the enhancement New feature label Oct 2, 2024
@slimbuck slimbuck requested a review from a team October 2, 2024 10:11
@slimbuck slimbuck self-assigned this Oct 2, 2024
@willeastcott
Copy link
Contributor

Cool. But I still strongly feel that this should be its own panel.

rollup.config.mjs Outdated Show resolved Hide resolved
src/file-handler.ts Outdated Show resolved Hide resolved
src/ui/view-panel.ts Outdated Show resolved Hide resolved
@slimbuck slimbuck merged commit 9ee5df7 into main Oct 2, 2024
2 checks passed
@slimbuck slimbuck deleted the camera-pose-dev branch October 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to add the "add camera model" function?
2 participants