Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update css build #169

Merged
merged 3 commits into from
Aug 19, 2024
Merged

Update css build #169

merged 3 commits into from
Aug 19, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Aug 19, 2024

Fixes: #166

Scss plugin struggles (bugs) when scss imports are encountered on windows.

This PR updates rollup build to output a css file instead and include it in html which happens to also work on windows.

@slimbuck slimbuck added the bug Something isn't working label Aug 19, 2024
@slimbuck slimbuck requested a review from a team August 19, 2024 09:32
@slimbuck slimbuck self-assigned this Aug 19, 2024
Copy link
Contributor

@isumygin-sc isumygin-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slimbuck slimbuck merged commit a1e5e50 into main Aug 19, 2024
2 checks passed
@slimbuck slimbuck deleted the css-dev branch August 19, 2024 13:52
@TonyDua
Copy link

TonyDua commented Aug 20, 2024

Thanks. It's working on windows now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorry, the latest version of Rollup still has path issues that cause startup anomalies
4 participants