Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gizmo consistent size, update key focus #131

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Make gizmo consistent size, update key focus #131

merged 3 commits into from
Jul 12, 2024

Conversation

slimbuck
Copy link
Member

@slimbuck slimbuck commented Jul 12, 2024

This PR:

  • sizes the transform gizmos to be consistent in screen space
  • adds an invisible dom element over the canvas which listens for pointer down and sets the focus to the body (this is to solve the issue where interacting with radio buttons etc results in lost keyboard focus)
  • make the entire body drop target instead of only canvas area

@slimbuck slimbuck added the bug Something isn't working label Jul 12, 2024
@slimbuck slimbuck requested a review from a team July 12, 2024 10:37
@slimbuck slimbuck self-assigned this Jul 12, 2024
@slimbuck slimbuck changed the title Make gizmo consistent size Make gizmo consistent size, update key focus Jul 12, 2024
@slimbuck slimbuck merged commit 2cc8b66 into main Jul 12, 2024
2 checks passed
@slimbuck slimbuck deleted the gizmo-scale branch July 12, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants