Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to make ingest lock timeout tests less flaky #4628

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

zoldar
Copy link
Contributor

@zoldar zoldar commented Sep 26, 2024

Changes

Can't tell for sure as this test fail is hard to reproduce, but I suspect there might be situations where reaching session processing step in the first ingest takes longer than the sleep before spinning up the second ingest.

@zoldar zoldar requested a review from a team September 26, 2024 08:42
Copy link
Member

@aerosol aerosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code_server overhead in interactive mode again? regardless, perhaps let's settle on eventually ?

@zoldar
Copy link
Contributor Author

zoldar commented Sep 26, 2024

@aerosol hmmm, I could track whether there's con_cache lock present with "eventually" in tight loop and only attempt the second ingest after that's satisfied. I'll see how feasible that is.

@aerosol
Copy link
Member

aerosol commented Sep 26, 2024

doesn't have to be con_cache specifically, since we're preloading the module in test_helper now

@aerosol
Copy link
Member

aerosol commented Sep 26, 2024

What I did to track it down previously:

  1. Run iex in MIX_ENV=test
  2. Set up flameon https://github.com/DockYard/flame_on/tree/main - looking at how @ruslandoga did it at flame on ruslandoga/plausible#301
  3. Run tests of interests from iex via Mix.Task.run

@zoldar zoldar added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit 9b6961c Nov 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants