Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shell-commands.rst #252

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Conversation

FlanOfHarmony
Copy link
Contributor

@FlanOfHarmony FlanOfHarmony commented Jun 27, 2022

Hi. First off: nice job on platformIO! It's a great project (Especially when there's no arduino package anymore on fedora). I just hope that one day you'll be able to get rid of microsoft's evil VScode Cpp extension as discussed here

But anyway, here's a commit, which deals with two issues I have with the instructions in shell-commands.rst.

  1. The first method is causing issues with python. Specifically, adding the $HOME/.platformio/penv/bin (wich contains a python3 symlink) breaks my python install. Without adding this directory to my $PATH variable, I'm having some ModuleNotFoundError errors while executing some (non related to PlatformIO) python programs i.e. something's wrong with python's virtual environment. I'm not a big python virtual environment expert so I don't know why, but without the directory in the $PATH variable everything is fine. To fix this I propose to use symlinks and ~/.local/bin instead (which is usually already filled with python files).

  2. On my freshly installed system, there is no /usr/share/bin/ directory. According to a quick google search, this is uncommon but can happen. Also according to the warning on this page of PlatformIO's documentation, requiring administrator permissions is against the spirit of PlatformIO so I thought about removing the method entirely, but I guess there are some use cases to a system-wide symlinks? When not "logged in as the user PlatformIO is installed and configured for"? Idk but I left it and added a small mkdir -p in case others do not have this directory on their systems.

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2022

CLA assistant check
All committers have signed the CLA.

@ivankravets ivankravets merged commit bee67b4 into platformio:develop Jun 29, 2022
@ivankravets
Copy link
Member

Thanks for the PR!

@FlanOfHarmony FlanOfHarmony deleted the patch-1 branch June 29, 2022 17:45
@FlanOfHarmony FlanOfHarmony restored the patch-1 branch June 29, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants