Fix to not incorrectly include TINYUSB on nrf52832 targets

[geeksville]

Rather than checking the name of the board check the name of the chip
which allows this code to work properly on any nrf52832. This processor
does not include a USB controller. TinyUSB can't build properly on this arch.

[geeksville]

Seems correct on my system, but I'll wait till I'm done with bringup to change this PR into not a draft.

[valeros]

It might be a good idea to add TinyUSB only when mcu is one of nRF52833, nRF52840.

[geeksville]

@valeros Instead of this change which is just doing the opposite - not adding it on a nrf52832? I'd bet the odds of USB being included on future chips is higher now that they have the IP.

[valeros]

Besides future chips, there are a few old ones like nRF52805, nRF52810, nRF52811, nRF52820 which don't have the USB controller but might be added to the framework. I'm simply suggesting to include TinyUSB only on the officially supported devices specified in https://github.com/hathach/tinyusb#supported-mcus

[geeksville]

ooh I see now! - that is a better idea. I'll tweak my PR to do that.

…

On Mon, Jul 13, 2020 at 7:27 AM Valerii Koval ***@***.***> wrote: Besides future chips, there are a few old ones like nRF52805, nRF52810, nRF52811, nRF52820 which don't have the USB controller but might be added to the framework. I'm simply suggesting to include TinyUSB only on the officially supported devices specified in https://github.com/hathach/tinyusb#supported-mcus — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABXB2JNEB5UYR6PYKS3HU3R3MKWXANCNFSM4OW2KZ5A> .

[geeksville]

btw - I updated my branch. Do you want this PR?

[geeksville]

I'm not sure if this project is still being maintained, but in case it is: I just updated my PR with the changes needed to correctly build the latest arduinonrf52 master on nrf52840 cpus (there is a new crypto lib dependency). I'm not sure if my fix is really the ideal fix, but I'm adding it in case it is useful for others.

[sachaw]

@valeros Could we please get this merged, we're trying to minimize the amount of out-of-sync forks we have.

I believe all the requested fixes have been performed.

Thanks.

[cujomalainey]

Just hit this as well, would appreciate a merge

[maxxafari]

Is this issue solved elsewhere?

[x3e]

Seems like this is still needed. A merge would be nice.