Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create remote directory during UploadFile #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xagent003
Copy link

While trying new change for creating Comms registry.json file, it works on upgrade. But failing on new DU with fresh hosts. The /etc/pf9/comms/ dir does not exist. So UploadFile is failing. Might need changes in pf9ctl to have the sftpClient do a MkdirAll on the filepath's dir, before it does the remote .Create:

Copy link
Member

@mithilarun mithilarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good. Could you add similar code to the DownloadFile function below too?

@nikhilbandi
Copy link
Contributor

@xagent003 , just wanted to know if this change should be part of the upcoming pf9ctl release.
CC: @anupbarve, @devidask27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants