Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/k8snetworkplumbingwg/network-attachment-definition-client from 1.6.0 to 1.7.5 #265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2024

Bumps github.com/k8snetworkplumbingwg/network-attachment-definition-client from 1.6.0 to 1.7.5.

Release notes

Sourced from github.com/k8snetworkplumbingwg/network-attachment-definition-client's releases.

v1.7.5

This release contains a fix related to the determination of the default interface, e.g. setting the default parameter to true in the network-status annotation based on the presence of a gateway in the CNI ADD success result ips.gateway and makes the determination of the default based on the first interface that has an associated value of gateway (using the interface index in the ips element in the CNI ADD success result).

This provides flexibility especially in CRI-O which uses the first interface and IP addresses for the pod.IP in Kubernetes, therefore. Containerd functionality is unchanged in that it uses the value for the IP addresses specifically

It's worth noting that CNI ADD success results which do not contain any interfaces will be discarded in this determination of the default, therefore it's recommended to set one with an associated gateway if aiming to have it be noted as the default.

v1.7.4

This release accounts for CNI plugins which do not use the sandbox field in results when calculating the network-status annotation, doing so for backwards compatibility for plugins which choose to not use this field (such as Calico)

v1.7.3

This release accounts for the sandox interfaces when reporting the interfaces in the network-status annotation; in case the CreateNetworkStatuses clients invoke it with a CNI result featuring non-sandbox interfaces as the first item in the list, this release accounts for that condition.

v1.7.2

When the CreateNetworkStatuses method was created to properly set the network-status annotation when a CNI result includes multiple interfaces in the return, it was found that it when setting the "default" parameter in the network-status, it was setting it to all the returned interfaces to true, which doesn't fit the NPWG net-attach-def specification.

This release fixes that issue by using the first interface in the CNI result set to "default": true for the cluster default network and not the following interfaces.

NOTE Do not use this version, use >= v1.7.3

v1.7.1

Adds the CreateNetworkStatuses method to properly set the network-status annotation when a CNI result includes multiple interfaces in the return.

For details of the before/after, see this gist: https://gist.github.com/dougbtv/1eb8ac2d61d494b56d65a6b236a86e61

For the related suggested update to the NPWG net-attach-def specification (for clarity only), see this proposal @ https://docs.google.com/document/d/1DUTV-o6E6zlRTKZkxeDhAeyGrmq03qPgPbU580Rm7-g/edit

v1.7.0

Adds MTU to network-status

Commits
  • 7d2def1 Merge pull request #73 from dougbtv/gw-for-default
  • 55f81d3 Assigns default=true on a multiple interface return for first interface with ...
  • 9b218a2 Merge pull request #72 from maiqueb/address-calico-not-defining-sandbox
  • ed6baad Preserve backwards compatibility of CreateNetworkStatus
  • 506cfda Merge pull request #71 from maiqueb/account-for-sandbox-ifaces-when-choosing-...
  • d8782ff Accont for non-sandbox interfaces when specifying the default network
  • d23f60f Merge pull request #70 from maiqueb/multiple-default-interfaces
  • afe49cd Comply with de-facto standar for multiple interfaces single ADD request
  • ec02fb3 Merge pull request #68 from dougbtv/networkstatus-multiple-interface-result
  • 38ceddc Adds CreateNetworkStatuses method which will handle CNI results with multiple...
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Oct 21, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/k8snetworkplumbingwg/network-attachment-definition-client-1.7.5 branch from 4cf3f1f to ff2e807 Compare November 18, 2024 18:40
@cruizen
Copy link
Contributor

cruizen commented Nov 18, 2024

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 18, 2024

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

…ient

Bumps [github.com/k8snetworkplumbingwg/network-attachment-definition-client](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client) from 1.6.0 to 1.7.5.
- [Release notes](https://github.com/k8snetworkplumbingwg/network-attachment-definition-client/releases)
- [Commits](k8snetworkplumbingwg/network-attachment-definition-client@v1.6.0...v1.7.5)

---
updated-dependencies:
- dependency-name: github.com/k8snetworkplumbingwg/network-attachment-definition-client
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@cruizen cruizen force-pushed the dependabot/go_modules/github.com/k8snetworkplumbingwg/network-attachment-definition-client-1.7.5 branch from ff2e807 to 212c64c Compare November 18, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant