Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(BnListbox): add style when is navigated by keyboard #15

Merged
merged 2 commits into from
Jul 28, 2023
Merged

style(BnListbox): add style when is navigated by keyboard #15

merged 2 commits into from
Jul 28, 2023

Conversation

fprebolledo
Copy link
Contributor

@fprebolledo fprebolledo commented Jul 28, 2023 •
edited
Loading

Context

  • Banano is a component library for use in our projects
  • We made a listbox component with its basics interactions, but when you navigate It with arrows, It does not shows any feedback of what is happening.

Changes

  • A ui:active selector has been added to the listbox styles to be activated when headless-ui calificates a option as active.
  • Also I added a PR template for futures PRs.

@fprebolledo
Copy link
Contributor Author

En Listbox, al navegar con las flechas del teclado no hay cambio de estilo que indique en que opción está parado

@fprebolledo fprebolledo requested a review from gmq July 28, 2023 15:34
@fprebolledo fprebolledo merged commit 63704d8 into master Jul 28, 2023
3 checks passed
@fprebolledo fprebolledo deleted the feat/active-color-bn-listbox branch July 28, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmq gmq gmq approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fprebolledo @gmq