-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unnest styles #14
Merged
Merged
Unnest styles #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
difernandez
force-pushed
the
unnest-styles
branch
from
July 27, 2023 15:40
aa1e9c8
to
8bd6766
Compare
fprebolledo
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. I left a comments about how have being passed classes to a component.
Now it expects a color class variant for each element that has varColor related changes
difernandez
force-pushed
the
unnest-styles
branch
from
July 28, 2023 15:21
8bd6766
to
1f1378e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
classes
, which is an object with keys that correspond to internal elements ofo a component, and allows to include new classes to those elements. This classes don't completely replace previous default styles, but should be able to override them if there is some overlapChanges
This PR flattens all selectors of default styles to just be single classes, so that classes prop can override them.
colors:
key in the.cjs
, in any sub element or modifier (or the block itself). Now the processing of thesecolors:
are changed in thetailwind/index.cjs
: it requires a color modifier class in the element itself. When using acolors:
inside a modifier class, just one-
is added, as BEM specifies that there should only be one modifier in a class name