-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to JupyterHub service #75
Conversation
f75fdde
to
410f046
Compare
27a6728
to
b706115
Compare
Thanks @trungleduc for looking into this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if this snapshot update is intended? It looks like the refresh icon appears instead of "Open Server"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The navbar changes look relevant due to the switch to the service. So it's likely only the refresh icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated snapshot is for the nav bar, the refresh icon, or the "Open Server" button depending on the runner's processing speed; sometimes it fires the server quickly enough to show the open server button.
We have a maxDiffPixelRatio: 0.001
config to catch this inconsistency
cc @yuvipanda this is one step towards #72 (in case you are interested in following progress on that) |
oooooh will look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes
This PR converts extra hub handlers into a hub-managed service. This service can be started by this command:
The available settings for this service are:
port
: Port of the service; defaults to 6789ip
: Internal IP of the service; defaults to 127.0.0.1default_memory_limit
: Default memory limit of a user server; defaults toNone
default_cpu_limit
: Default CPU limit of a user server; defaults toNone
machine_profiles
: Instead of entering directly the CPU and Memory value,tljh-repo2docker
can be configured with pre-defined machine profiles and users can only choose from the available option; defaults to[]
Here is an example of registering
tljh_repo2docker
's service with JupyterHub