-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add releaser workflow #74
Conversation
fd42905
to
191a262
Compare
.github/workflows/prep-release.yml
Outdated
id: prep-release | ||
uses: jupyter-server/jupyter_releaser/.github/actions/prep-release@v2 | ||
with: | ||
token: ${{ secrets.ADMIN_GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't have a bot for the plasmabio
org, wondering if we should try to use a GitHub app instead, as suggested by this change in the releaser repo: jupyter-server/jupyter_releaser#557
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, could you create an app for the plasmabio
org?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check, but not sure I have admin rights on the org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No I don't have access to the organization settings at the moment.
cc @pierrepo who might be able to help with this. For context we are trying to setup automated releases for tljh-repo2docker
using the Jupyter Releaser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jtpio is here anything I could do for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's possible to give use rights to manage apps here: https://github.com/organizations/plasmabio/settings/apps. I dont' have access to that URL but normally it should be the right one.
Not sure if that will be enough for us to create a GitHub app for the organization, or if we would also need to become owners of the org. Normally it should be enough according to the docs:
You can register a GitHub App under your personal account, under an organization that you own, or under an organization that has granted you permission to manage all apps owned by the organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be ok @jtpio :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Just published a placeholder package to PyPI: https://pypi.org/project/tljh-repo2docker/ Add setup the trusted publisher: |
Great! |
Following https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo_from_repo.html. We now have the GitHub App created: And the two secrets defined in this repo for the I haven't added a ruleset yet for now to keep things simple, but we can consider adding it later. |
@jtpio is it ready to go? |
I think so. Let's merge and try to make a release? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes #71