Initial version of the application. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This code is obtained from the samples supplied by iText.
…rogrammatically and storing the certificate chain.
…ave signature classes implement the IExternalSignatureWithChain.
Needed to be able to connect from the javascript in the page to the localhost.
…ted components file.
…vate keys. In Pkcs11 logout user only if it is logged in. Use RsaCng in tests.
… providing the pin.
…c. info at solution level.
dimarobert
commented
Jul 28, 2022
Comment on lines
+6
to
+11
| <Company>PlantAnApp, iText Group</Company> | ||
| <Authors>Plant An App, iText Group</Authors> | ||
| <Copyright>(C) Plant An App, (C) iText Group</Copyright> | ||
| <PackageLicenseFile>C:\Work\Projects\PdfAutoSignerAndJava\_code\PlantAnApp.PdfAutoSigner\license.rtf</PackageLicenseFile> | ||
| <PackageRequireLicenseAcceptance>True</PackageRequireLicenseAcceptance> | ||
| <RepositoryUrl>https://github.com/razvanionapp/PlantAnApp.PdfAutoSigner.git</RepositoryUrl> |
There was a problem hiding this comment.
I think that this should be updated.
Comment on lines
+10
to
+11
| **/hello-signed-pkcs11.pdf | ||
| **/hello-signed-cert.pdf |
There was a problem hiding this comment.
I do not think we should have these here.
Comment on lines
+60
to
+61
| byte[] buffer = new byte[file.Length]; | ||
| buffer = outputMemStream.ToArray(); |
There was a problem hiding this comment.
Suggested change
| byte[] buffer = new byte[file.Length]; | |
| buffer = outputMemStream.ToArray(); | |
| byte[] buffer = outputMemStream.ToArray(); |
| return BadRequest("A signature must be selected."); | ||
| } | ||
|
|
||
| var inputMemStream = new MemoryStream(); |
There was a problem hiding this comment.
this should be closed / disposed at some point. (why not create it with a using statement?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.