Skip to content

Commit

Permalink
resolve merge conflicts against main
Browse files Browse the repository at this point in the history
Signed-off-by: Vicent Marti <[email protected]>
  • Loading branch information
vmg committed Sep 27, 2023
1 parent 51585e9 commit 35e8724
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 111 deletions.
12 changes: 6 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
export GOBIN=$(PWD)/bin
export PROTOBUF_ROOT=$(PWD)/_vendor/protobuf-21.12

.PHONY: test gen-conformance gen-include gen-wkt genall bin/protoc-gen-go bin/protoc-gen-go-vtproto
.PHONY: install test gen-conformance gen-include gen-wkt genall bin/protoc-gen-go bin/protoc-gen-go-vtproto

protoc-gen: bin/protoc-gen-go-vtproto bin/protoc-gen-go
install: bin/protoc-gen-go-vtproto bin/protoc-gen-go

bin/protoc-gen-go-vtproto:
go install -tags protolegacy ./cmd/protoc-gen-go-vtproto

bin/protoc-gen-go:
go install -tags protolegacy google.golang.org/protobuf/cmd/protoc-gen-go

gen-conformance: protoc-gen
gen-conformance: install
$(PROTOBUF_ROOT)/src/protoc \
--proto_path=$(PROTOBUF_ROOT) \
--go_out=conformance --plugin protoc-gen-go="${GOBIN}/protoc-gen-go" \
Expand Down Expand Up @@ -48,7 +48,7 @@ gen-wkt: bin/protoc-gen-go-vtproto
$(PROTOBUF_ROOT)/src/google/protobuf/timestamp.proto \
$(PROTOBUF_ROOT)/src/google/protobuf/wrappers.proto

gen-testproto: gen-wkt-testproto protoc-gen
gen-testproto: gen-wkt-testproto install
$(PROTOBUF_ROOT)/src/protoc \
--proto_path=testproto \
--proto_path=include \
Expand All @@ -63,7 +63,7 @@ gen-testproto: gen-wkt-testproto protoc-gen
testproto/proto2/scalars.proto \
|| exit 1;

gen-wkt-testproto: protoc-gen
gen-wkt-testproto: install
$(PROTOBUF_ROOT)/src/protoc \
--proto_path=testproto \
--proto_path=include \
Expand All @@ -75,7 +75,7 @@ gen-wkt-testproto: protoc-gen

genall: gen-include gen-conformance gen-testproto gen-wkt

test: protoc-gen gen-conformance
test: install gen-conformance
go test -short ./...
go test -count=1 ./conformance/...
GOGC="off" go test -count=1 ./testproto/pool/...
89 changes: 0 additions & 89 deletions conformance/marshal.log

This file was deleted.

4 changes: 2 additions & 2 deletions generator/generatedfile.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ func (b *GeneratedFile) ShouldPool(message *protogen.Message) bool {

func (b *GeneratedFile) Alloc(vname string, message *protogen.Message) {
if b.ShouldPool(message) {
b.P(vname, " := ", message.GoIdent, `FromVTPool()`)
b.P(vname, " := ", message.GoIdent.GoName, `FromVTPool()`)
} else {
b.P(vname, " := new(", message.GoIdent, `)`)
b.P(vname, " := new(", message.GoIdent.GoName, `)`)
}
}

Expand Down
2 changes: 1 addition & 1 deletion types/known/anypb/any_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/known/durationpb/duration_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/known/emptypb/empty_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/known/fieldmaskpb/field_mask_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion types/known/timestamppb/timestamp_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions types/known/wrapperspb/wrappers_vtproto.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 35e8724

Please sign in to comment.