Add tolerable replication lag value #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
GuptaManan100
force-pushed
the
fix-prs-lag
branch
from
52e24fc to
4981f40
Compare
deepthi
reviewed
Dec 11, 2023
frouioui
approved these changes
Dec 11, 2023
|
Vitess operator only issues PlannedReparentShard when it needs to drain a tablet. The timeout for that PRS is not yet configurable, so I think it is okay to have a hard-coded value for now. If we feel the need to make them configurable, we can add them as a follow-up. |
systay
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the operator, we are calling PlannedReparentShard from the wrangler and an argument to that was recently added to it that specifies the amount of replication lag considered to be tolerable when initiating a PRS.
The vitess change was made in the PR vitessio/vitess#14634