Fix Release script to work with any image used in the yaml files #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l files Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
frouioui
approved these changes
Oct 10, 2023
GuptaManan100
pushed a commit
that referenced
this pull request
Oct 12, 2023
GuptaManan100
pushed a commit
that referenced
this pull request
Oct 12, 2023
Signed-off-by: Manan Gupta <[email protected]>
This was referenced Oct 12, 2023
GuptaManan100
added a commit
that referenced
this pull request
Oct 13, 2023
[release-2.11] Fix Release script to work with any image used in the yaml files #487
GuptaManan100
added a commit
that referenced
this pull request
Oct 13, 2023
[release-2.10] Fix Release script to work with any image used in the yaml files #487
GuptaManan100
added a commit
that referenced
this pull request
Oct 13, 2023
[release-2.9] Fix Release script to work with any image used in the yaml files #487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the release script was opinionated about what yaml files should be using MySQL 5.7 and what should be using MySQL 8.0 images. This however caused issues because we switch around this as part of development and don't always update the release script.
In this PR, I have changed the way the release script works by changing the sed commands, such that now the release script conserves the image variant to what it already is. This is the intended and correct behavior because when we do a release, we only intend to change the release number in the yaml files and not their variant.