Add a new field called "name" to VitessShardTabletPool as part of x-kubernetes-list-map-keys #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type in a given cell Signed-off-by: yoheimuta <[email protected]>
|
|
|
Thank you for the review! I will address these two points and make the necessary fixes. |
Signed-off-by: Yohei Yoshimuta <[email protected]>
…rnalDatastore Signed-off-by: Yohei Yoshimuta <[email protected]>
yoheimuta
force-pushed
the
support-more-VitessShardTabletPool
branch
from
1bddd17 to
3695721
Compare
yoheimuta
changed the title
|
@deepthi Hi, is there anything missing in this PR? |
frouioui
reviewed
Oct 5, 2023
pkg/operator/vttablet/uid.go
Outdated
| @@ -43,11 +43,30 @@ lead time to develop a smarter way to handle tablet identity and MySQL server | |||
| IDs in Vitess itself. | |||
|
|
|||
| WARNING: DO NOT change the behavior of this function, as that may result in | |||
| the deletion and recreation of all tablets. | |||
|
|
|||
There was a problem hiding this comment.
nit: we can remove this extra line i think
There was a problem hiding this comment.
Thank you for your review!
I fixed it: 62ea41d
Signed-off-by: Yohei Yoshimuta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new field named
"index""name" to thex-kubernetes-list-map-keysof TabletPools. It enables the presence of multiple TabletPool instances with a specific tablet type in a given cell.By assigning a default value of
0an empty string to theindexname, the existing users and most use cases remain unaffected. Theindexname value can be explicitly set toa value greater than 0something only when building a redundant system with unmanaged tablets.Related Issue(s)