Update connection to work for multi-keyspace databases #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting database to `@primary`, all subsequent DDL will be routed by vitess to the correct keyspace. Previously, by setting `database`, we were targeting a single keyspace by default. With the `@primary` change, any changes to existing tables will be routed correctly. When using `create_table`, the keyspace still needs to be specified. Will do a follow up PR to make creating tables easier.
no-itsbackpack
approved these changes
Apr 1, 2024
nickvanw
approved these changes
Apr 1, 2024
iheanyi
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By setting database to
@primary, all DDL will be routed by vitess to the correct keyspace.Previously, by setting
database, we were targeting a single keyspace by default.With the
@primarychange, any changes to existing tables will be routed correctly. When usingcreate_table, the keyspace still needs to be specified. Will do a follow up PR to make creating tables easier.I also explored leaving it
nil. The problem with that is: Rails will fallback to whatever is set indatabase.yml. Which overrides the nil and sets a database name for us. Using@primarymakes everything just work without any database.yml hacks.