Disable schema dump after running migrations + improve SSL cert #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For: #17 This checks common CA paths and adds it to the connection string.
- sslca doesnt need an underscore For the schema dump. I've found that when rails generates schema.rb or structure.sql, it runs an incredible amount of queries to construct dump. Normally, with local mysql this is fine because there is nearly no latency per query. When running this against a cloud database, it adds up very quickly. One of our example databases takes a full minute to dump (my laptop is 30ms from the database). By adding `schema_dump=`, this sets the Rails config for schema_dump to nil. Telling Rails not to run the dump. `schema_dump=false` does not work because this sets it to a string, which rails interprets at the filename where we want the dump stored.
mscoutermarsh
changed the title
ayrton
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17
Disabling schema dump
For the schema dump. I've found that when rails generates schema.rb or structure.sql, it runs an incredible amount of queries to construct the dump.
Normally, with local mysql this is fine because there is nearly no latency per query. When running this against a cloud database, it adds up very quickly.
One of our example databases takes a full minute to dump (my laptop is 30ms from the database).
By adding
schema_dump=, this sets the Rails config for schema_dump tonil. Telling Rails not to run the dump.schema_dump=falsedoes not work because this sets it to a string, which rails interprets at the filename where we want the dump stored.SSL
To make this more reliable for more environments. We now check the most common SSL paths for a cert. If we find one, then we pass it.