Use .NET builtin JsonNode instead of 3rd-party #349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line 110 in _logger.Information() method from '{DiffCOunt}' to '{DiffCount}'
…naryJsonConverter.cs' file to use 'System.Text.Json.Nodes.JsonNode' instead of 'NewtonSoft.Json.JObject', and also switched to 'System.Text.Json' types in all related files
TheMarvelFan
changed the title
TheMarvelFan
changed the title
moreal
changed the title
moreal
changed the title
moreal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #342
Below are the listed files that required modification to 'System.Text.Json' types:
Mimir.MongoDB/Bson/Serialization/Serializers/Lib9c/Items/TradableMaterialSerializer.cs
Mimir.MongoDB/Json/Converters/BigIntegerJsonConverter.cs
Mimir.MongoDB/Json/Converters/MaterialAndIntDictionaryJsonConverter.cs
Mimir.MongoDB/Json/Extensions/MimirBsonDocumentExtensions.cs
Note: Please merge PR #348 before merging this to avoid potential merge conflicts.