Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implements many serializers for ItemBase relates #340

Merged
merged 20 commits into from
Sep 25, 2024

Conversation

boscohyun
Copy link
Member

@boscohyun boscohyun commented Sep 24, 2024

Background

We need to declare how the ItemBase related types to deserialize from BsonDocument to object of specific type.

Changes

  • Implements default constructors and apply BsonIgnore attribute to Bencoded properties to all of types in the Lib9c.Models namespace.
  • Implements or improve Json converters:
    • BigIntegerJsonConverter
    • MaterialAndIntDictionaryJsonConverter
  • Implements and register IBsonSerializers of all ItemBase relates types.
  • Handle exceptions in CombinationSlotStateHandler.
  • Upgrade package versions.
  • Refactor ItemFactory.Create(), MongoDbService.
  • Code clean up:
    • Remove Mimir.Factories.StatMapFactory.

@boscohyun boscohyun self-assigned this Sep 24, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@boscohyun boscohyun requested review from moreal, Atralupus and a team September 25, 2024 00:59
@boscohyun boscohyun marked this pull request as ready for review September 25, 2024 01:06
@boscohyun boscohyun requested review from Atralupus and removed request for Atralupus September 25, 2024 06:53
@boscohyun boscohyun added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 37498f5 Sep 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants