Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use System.Text.Json.Nodes.JsonNode instead of JObject #342

Open
moreal opened this issue Sep 25, 2024 · 3 comments
Open

Use System.Text.Json.Nodes.JsonNode instead of JObject #342

moreal opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels

Comments

@moreal
Copy link
Contributor

moreal commented Sep 25, 2024

Background

Now, it uses JObject class of Newtonsoft.Json to parse JSON string and to handle JSON as dynamic object, not class type.
But there is a builtin alternative for the JObject, and it is System.Text.Json.Nodes.JsonNode.

You can refer the below items:

If it uses JSON as readonly mode, you can use JsonDocument

Work items

@TheMarvelFan
Copy link

Hi, is anyone working on this issue?
If not, I would like to take it up.

@Atralupus
Copy link
Member

Hi, is anyone working on this issue? If not, I would like to take it up.

Sure, that's possible! However, since you've already been assigned two GFI tasks, we won't be able to assign more GFIs to you for now.
Happy hacking!

@TheMarvelFan
Copy link

TheMarvelFan commented Oct 1, 2024

Hi @moreal ,

Hacktoberfest has now started accepting contributions, so this PR can be merged now.
But, it is not detecting my PR for this issue as a part of Hacktoberfest. This is most probably because of the label of 'hacktoberfest' on this issue needs to start with a captial 'H', i.e., 'Hacktoberfest'.
Once this is done, I think it will detect my PR, and it can then be merged.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants