Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception on libplanet for zero byte prive key #3976

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Raise exception on libplanet for zero byte prive key #3976

merged 1 commit into from
Oct 27, 2024

Conversation

Songhee120
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@OnedgeLee OnedgeLee added the no changelog Bypasses changelog check label Oct 27, 2024
@OnedgeLee OnedgeLee added the hacktoberfest Newcomer-welcoming issues for Hacktoberfest label Oct 27, 2024
@OnedgeLee OnedgeLee marked this pull request as ready for review October 27, 2024 06:55
@OnedgeLee OnedgeLee linked an issue Oct 27, 2024 that may be closed by this pull request
Raise exception when zero byte array applied as a argument on PrivateKey generation #2095
Closed
@OnedgeLee OnedgeLee merged commit 625e617 into planetarium:main Oct 27, 2024
24 checks passed
riemannulus
riemannulus reviewed Oct 27, 2024
View reviewed changes
test/Libplanet.Tests/Crypto/PrivateKeyTest.cs
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check EOF. @Songhee120 @OnedgeLee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riemannulus riemannulus riemannulus left review comments

@OnedgeLee OnedgeLee OnedgeLee approved these changes

Assignees

@Songhee120 Songhee120

Labels
hacktoberfest Newcomer-welcoming issues for Hacktoberfest no changelog Bypasses changelog check
Projects
Planetarium open-source contributor
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise exception when zero byte array applied as a argument on PrivateKey generation
4 participants
@Songhee120 @CLAassistant @riemannulus @OnedgeLee