Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getavatarstate signer check #2849

Merged
merged 3 commits into from
Sep 25, 2024
Merged

fix getavatarstate signer check #2849

merged 3 commits into from
Sep 25, 2024

Conversation

eugene-doobu
Copy link
Member

액션에서 Singer 체크를 추가합니다

@eugene-doobu eugene-doobu added this to the v230.0.0 milestone Sep 24, 2024
@eugene-doobu eugene-doobu self-assigned this Sep 24, 2024
U-lis
U-lis previously requested changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@U-lis U-lis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

signer 체크만 하면 되는데 GetAvatarState 에서 inventory, quest 뭐 이런것도 다 들고오고 있는 것 같습니다. 뒤에 arg 로 false 들을 넣어서 안 가져오게 하면 좋을 것 같습니다.

Lib9c/Action/AdventureBoss/UnlockFloor.cs Show resolved Hide resolved
@U-lis U-lis self-requested a review September 25, 2024 08:18
@eugene-doobu eugene-doobu mentioned this pull request Sep 25, 2024
Closed
@eugene-doobu eugene-doobu marked this pull request as draft September 25, 2024 08:20
@eugene-doobu eugene-doobu marked this pull request as ready for review September 25, 2024 08:20
@eugene-doobu eugene-doobu merged commit 10015e1 into planetarium:development Sep 25, 2024
8 checks passed
@eugene-doobu eugene-doobu deleted the feature/fix-getavatarstate-signer-check branch September 25, 2024 08:21
@eugene-doobu eugene-doobu linked an issue Sep 25, 2024 that may be closed by this pull request
fix GetAvatarState Signer check #2848
Closed
@eugene-doobu
Copy link
Member Author

@U-lis #2857 별도 이슈 생성해두었습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipdae ipdae ipdae approved these changes

@tyrosine1153 tyrosine1153 Awaiting requested review from tyrosine1153

@U-lis U-lis Awaiting requested review from U-lis

Assignees

@eugene-doobu eugene-doobu

Labels
None yet
Projects
Nine Chronicles
Status: Done
Milestone
v230.0.0
Development

Successfully merging this pull request may close these issues.

fix GetAvatarState Signer check
3 participants
@eugene-doobu @ipdae @U-lis