fix grinding #2829
Merged
fix grinding #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tyrosine1153
commented
Sep 12, 2024
tyrosine1153
commented
- fix grinding reward
- add Equipments duplicate check
eugene-doobu
approved these changes
Sep 12, 2024
sonohoshi
reviewed
Sep 13, 2024
Comment on lines
+49
to
+52
| if (EquipmentIds.Count != EquipmentIds.Distinct().Count()) | ||
| { | ||
| throw new InvalidItemCountException(); | ||
| } |
There was a problem hiding this comment.
그럼 테스트 추가해야한다고 이슈만 남겨놓고 머지하시죠 @tyrosine1153
ipdae
approved these changes
Sep 13, 2024
tyrosine1153
force-pushed
the
bugfix/grinding
branch
from
8f80b3f
to
56eaa07
Compare
U-lis
approved these changes
Sep 13, 2024
tyrosine1153
force-pushed
the
bugfix/grinding
branch
from
f29079a
to
c9ef100
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.