fix full constume preview #6394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyrosine1153
requested review from
sonohoshi,
jonny-jeahyunchoi and
eugene-doobu
as code owners
|
@tyrosine1153 The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:
Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:
|
sonohoshi
approved these changes
Nov 18, 2024
| var costumes = new List<Costume> { costume, }; | ||
| Game.Game.instance.Lobby.FriendCharacter.Set(avatarState, costumes, equipments); | ||
| Game.Game.instance.Lobby.FriendCharacter.SetForCostumes(costumes); |
There was a problem hiding this comment.
이걸 손대는게 로비에 있는 캐릭터에 영향이 가는걸까요?
로비에 있는 캐릭터는 기존 코스튬 착용 규칙을 따라가야 할 것 같습니다
There was a problem hiding this comment.
LobbyCharacter, FriendCharacter는 클래스하고 오브젝트, 렌더 텍스쳐가 분리되어있습니당
그래서 로비 캐릭터는 본인 아바타 입은거 보여줄 때 (로비, 인벤토리, 전투 준비화면)에서만 쓰고, 칭구 캐릭터는 다른 유저 보여줄 때 쓰려고 만들었는데 그냥 UI에서 아바타 보여줄때 여기저기 써요. 보통 사용할 때마다 Set하기 때문에 같은 캐릭터 끼리도 문제는 없을겁니당.
eugene-doobu
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description