Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event feature polishing #6331

Merged
merged 7 commits into from
Nov 14, 2024
Merged

event feature polishing #6331

merged 7 commits into from
Nov 14, 2024

Conversation

tyrosine1153
Copy link
Contributor

Description

#6318

@github-actions github-actions bot added this to the v250.0.0 milestone Nov 14, 2024
@github-actions GitHub Actions
Copy link

@tyrosine1153 The versions of bundled Libplanet assemblies and Libplanet submodule vendored by Lib9c apparently do not match:

  • Libplanet submdoule:
  • Libplanet.Action.dll: 5.3.2-alpha.1
  • Libplanet.Common.dll: 5.3.2-alpha.1
  • Libplanet.Crypto.dll: 5.3.2-alpha.1
  • Libplanet.Mocks.dll: 5.3.2-alpha.1
  • Libplanet.RocksDBStore.dll: 5.3.2-alpha.1
  • Libplanet.Store.dll: 5.3.2-alpha.1
  • Libplanet.Types.dll: 5.3.2-alpha.1
  • Libplanet.dll: 5.3.2-alpha.1

Leave a comment in this pull_request with the following command to let the bot upgrade bundled Libplanet assemblies:

/update-libplanet-dlls

@tyrosine1153 tyrosine1153 changed the base branch from development to ui/eventpopup-edit241111 November 14, 2024 02:07
Base automatically changed from ui/eventpopup-edit241111 to development November 14, 2024 02:23
@tyrosine1153 tyrosine1153 merged commit e79d606 into development Nov 14, 2024
2 checks passed
@tyrosine1153 tyrosine1153 deleted the feature/event-polishing branch November 14, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonny-jeahyunchoi jonny-jeahyunchoi jonny-jeahyunchoi approved these changes

@sonohoshi sonohoshi Awaiting requested review from sonohoshi sonohoshi is a code owner

@eugene-doobu eugene-doobu Awaiting requested review from eugene-doobu eugene-doobu is a code owner

Assignees

@tyrosine1153 tyrosine1153

Labels
None yet
Projects
Nine Chronicles
Status: Merged
Milestone
v250.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tyrosine1153 @jonny-jeahyunchoi