Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global notification #4004

Closed
wants to merge 2 commits into from
Closed

Add global notification #4004

wants to merge 2 commits into from

Conversation

U-lis
Copy link
Contributor

@U-lis U-lis commented Jan 23, 2024

Description

Add global notification for legendary aura/rune summon (the criteria is just for test)

@U-lis U-lis added the enhancement New feature or request label Jan 23, 2024
@U-lis U-lis self-assigned this Jan 23, 2024
@U-lis U-lis requested a review from a team as a code owner January 23, 2024 07:46

This PR has 79 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Small
Size       : +79 -0
Percentile : 31.6%

Total files changed: 3

Change summary by file extension:
.cs : +76 -0
.meta : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@U-lis U-lis added this to the v140.0.0 milestone Jan 25, 2024
@U-lis U-lis requested a review from ipdae February 1, 2024 01:44
@U-lis U-lis marked this pull request as draft February 1, 2024 01:44
@ipdae ipdae removed this from the v150.0.0 milestone Feb 22, 2024
@U-lis
Copy link
Contributor Author

U-lis commented Oct 14, 2024

이건 나중에 하게 되면 아예 새로 만들어야 할 것 같기도 한데... 일단 가까운 시일 내에 진행할 것 같지는 않으니 PR 은 닫아두겠습니다.

@U-lis U-lis closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants