Add external-dns hostname to rudolf-service #2146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseiker
force-pushed
the
rudolf-externaldns
branch
from
61ea270
to
812df3b
Compare
sky1045
approved these changes
Oct 31, 2024
|
it's covered by with clause, the external-dns annotations will be ignored if hostname is not set |
eseiker
force-pushed
the
rudolf-externaldns
branch
from
812df3b
to
c77db04
Compare
External loadbalancer to be removed, replaced with and merged into gateway gradually
eseiker
force-pushed
the
rudolf-externaldns
branch
from
c77db04
to
0e98548
Compare
sky1045
approved these changes
Oct 31, 2024
moreal
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External loadbalancer might be removed, replaced with and merged into gateway gradually
This change intends to specify NLB availability zone