Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for September 2023 #1603

Merged
merged 37 commits into from
Sep 29, 2023
Merged

Updates for September 2023 #1603

merged 37 commits into from
Sep 29, 2023

Conversation

Hans5958
Copy link
Member

@Hans5958 Hans5958 commented Sep 27, 2023

Few code changes for updates to the Atlas. The primary focus is the inclusion of TFC, but other changes can be vetted.

Resolves #59
Resolves #60
Resolves #247
Resolves #290

@Hans5958 Hans5958 requested a review from a team as a code owner September 27, 2023 07:20
@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for place-atlas-2023 ready!

Name Link
🔨 Latest commit 6763966
🔍 Latest deploy log https://app.netlify.com/sites/place-atlas-2023/deploys/65168285294aa800087b4ed0
😎 Deploy Preview https://deploy-preview-1603--place-atlas-2023.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the atlas data: direct Changes to the Atlas data by editing the atlas.json file directly label Sep 27, 2023
Copy link
Contributor

@AnonymousRandomPerson AnonymousRandomPerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not possible to proceed after adding a TFC period and drawing a polygon.

@Hans5958
Copy link
Member Author

It's not possible to proceed after adding a TFC period and drawing a polygon.

Try again now?

- Change back to CacheFirst strategy
- Extend Cache-Control to 4 weeks to match SW cache
- Capitalize Cache-Control
- Add Cache-Control for /_js/ and /_css/
- Remove background sync when caching canvas
- Extend caching to 1 year for canvas and 4 weeks for other resources
- Add and remove comments
- Prefetch atlas.json
- Cache hashed resources to one year
- Ignore atlas.json on Parcel to prefetch
- Remove atlas.json prefetch, not having significant improvement
The Team section is now linked for PAI to we can centralized updating on one place, and with nicer display.
The Credits section (about.html) and Contributors section (README) now links to each other
The project contributors have been reworded, and the second section of contributors now named as Info Contributors (as they contribute in terms of data/info)
Mention as "Entry Contributors" instea. The word "entry" is quite usual here
- Mention AGPL-3.0 on footer
- Move link to source code to navbar
- Fix navbar styling
- Shorten to "Powered by Netlify" (hopefully no need for full sentence since badge is on the org website)
Have to aware that Netlify may inject a script. The project itself is under a free license.
Turns out noopener is not needed when target="_blank", also adjusts some to have referrers
- Use "an interactive map" to replace "an atlas"
- Add link to announcement
- Rename #contributors-wrapper to #entry-contributors-wrapper
- Only remove underline on #entry-contributors-wrapper
- Separate section of Stefano, add credit to indicate a personal message
@Hans5958 Hans5958 force-pushed the staging/code branch 2 times, most recently from 15b5367 to dde0be9 Compare September 29, 2023 07:52
@Hans5958 Hans5958 merged commit dd3815c into master Sep 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atlas data: direct Changes to the Atlas data by editing the atlas.json file directly
Projects
None yet
2 participants