-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for September 2023 #1603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for place-atlas-2023 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
atlas data: direct
Changes to the Atlas data by editing the atlas.json file directly
label
Sep 27, 2023
AnonymousRandomPerson
requested changes
Sep 27, 2023
Hans5958
force-pushed
the
staging/code
branch
from
September 28, 2023 02:57
9f2c451
to
d044062
Compare
AnonymousRandomPerson
requested changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not possible to proceed after adding a TFC period and drawing a polygon.
Try again now? |
AnonymousRandomPerson
requested changes
Sep 28, 2023
Hans5958
force-pushed
the
staging/code
branch
from
September 28, 2023 05:03
80df20e
to
e010f10
Compare
AnonymousRandomPerson
requested changes
Sep 28, 2023
Hans5958
force-pushed
the
staging/code
branch
from
September 28, 2023 05:34
e010f10
to
caa8abc
Compare
Hans5958
force-pushed
the
staging/code
branch
from
September 28, 2023 05:48
caa8abc
to
2d15062
Compare
AnonymousRandomPerson
approved these changes
Sep 29, 2023
Resolves #290
- Change back to CacheFirst strategy - Extend Cache-Control to 4 weeks to match SW cache - Capitalize Cache-Control
- Add Cache-Control for /_js/ and /_css/ - Remove background sync when caching canvas - Extend caching to 1 year for canvas and 4 weeks for other resources - Add and remove comments
- Prefetch atlas.json - Cache hashed resources to one year
- Ignore atlas.json on Parcel to prefetch
- Remove atlas.json prefetch, not having significant improvement
The Team section is now linked for PAI to we can centralized updating on one place, and with nicer display. The Credits section (about.html) and Contributors section (README) now links to each other The project contributors have been reworded, and the second section of contributors now named as Info Contributors (as they contribute in terms of data/info)
Mention as "Entry Contributors" instea. The word "entry" is quite usual here
- Mention AGPL-3.0 on footer - Move link to source code to navbar - Fix navbar styling - Shorten to "Powered by Netlify" (hopefully no need for full sentence since badge is on the org website)
Have to aware that Netlify may inject a script. The project itself is under a free license.
Resolves #247
Turns out noopener is not needed when target="_blank", also adjusts some to have referrers
- Use "an interactive map" to replace "an atlas" - Add link to announcement - Rename #contributors-wrapper to #entry-contributors-wrapper - Only remove underline on #entry-contributors-wrapper - Separate section of Stefano, add credit to indicate a personal message
Hans5958
force-pushed
the
staging/code
branch
2 times, most recently
from
September 29, 2023 07:52
15b5367
to
dde0be9
Compare
Hans5958
force-pushed
the
staging/code
branch
from
September 29, 2023 07:53
dde0be9
to
6763966
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few code changes for updates to the Atlas. The primary focus is the inclusion of TFC, but other changes can be vetted.
Resolves #59
Resolves #60
Resolves #247
Resolves #290