Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust updateBackground to solve potential bugs #1457

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Hans5958
Copy link
Member

@Hans5958 Hans5958 commented Jul 31, 2023

Some said that there are problems where it gets stuck. This PR attempts to fix it but it should functionally equivalent, so not sure if this has been fixed.

TODO Remove [DEV] commits before merge

@netlify
Copy link

netlify bot commented Jul 31, 2023

Deploy Preview for place-atlas-2023 ready!

Name Link
🔨 Latest commit e8a92e3
🔍 Latest deploy log https://app.netlify.com/sites/place-atlas-2023/deploys/64c7ac173e6e5900084fcad6
😎 Deploy Preview https://deploy-preview-1457--place-atlas-2023.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Hans5958 Hans5958 changed the title Adjust updateBackground to solve potential bugs Adjust updateBackground to solve potential bugs Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023

Qodana for JS

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@Hans5958 Hans5958 marked this pull request as draft July 31, 2023 01:52
@Hans5958 Hans5958 force-pushed the updatebackground-adjustments branch 2 times, most recently from be84f78 to d11fee8 Compare July 31, 2023 03:26
@Hans5958 Hans5958 force-pushed the updatebackground-adjustments branch from d11fee8 to e8a92e3 Compare July 31, 2023 12:41
@Hans5958 Hans5958 marked this pull request as ready for review July 31, 2023 12:42
@Hans5958 Hans5958 force-pushed the updatebackground-adjustments branch from e8a92e3 to 6ce7abc Compare July 31, 2023 12:42
@Hans5958 Hans5958 merged commit 006670e into placeAtlas:master Jul 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant