Code changes (04/08) #1418
Merged
Code changes (04/08) #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #612
Last time it was period-first (shown by period, then filter for search), now it is filter-first
It is unused, and I think it can be substituted with the layer system
Also make updateViewFromHash work again
…into feat/decreases_lineCanvas_rerender # Conflicts: # web/_js/main/main.js # web/_js/main/view.js
It has been covered in literally the next lines
✅ Deploy Preview for place-atlas-2023 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Qodana for JSIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
# Conflicts: # web/_js/main/main.js # web/_js/main/view.js
|
Okay, merging in no earlier than 2 August, 00:00 GMT |
|
Nope, something went wrong, pushed some fixes. Will merge in 04/08. |
AnonymousRandomPerson
added a commit
that referenced
this pull request
Aug 4, 2023
Revert "Merge pull request #1418 from placeAtlas/staging/code"
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This are significant code changes for this period of time. Check the commits for more information.