Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement owner subcommand #159

Closed
wants to merge 1 commit into from

Conversation

popzxc
Copy link
Contributor

@popzxc popzxc commented Jul 17, 2024

cargo owner, but for workspaces.
The implementation is straightforward, it simply executes cargo owner for each package.

Initially, I've added a test for cargo ws owner --list, but turns out that any cargo owner command requires a token to be present (see this workflow failure), so I removed it.

@pksunkara
Copy link
Owner

Can this be done with cargo ws exec instead? What's the need for new command?

@popzxc
Copy link
Contributor Author

popzxc commented Jul 17, 2024

Oh, I totally missed it. Yes, I think it can be done via cargo ws exec.
cargo ws owner may be a bit more intuitive/convenient, but I'm not sure if the benefits here outweigh the maintenance cost.
Feel free to close this PR if you don't think this functionality is needed.

@pksunkara
Copy link
Owner

If the benefits here outweigh the maintenance cost.

I don't think they do. Appreciate the proposal though.

@pksunkara pksunkara closed this Jul 17, 2024
@popzxc popzxc deleted the add-owner-command branch July 17, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants