Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkp/pkp-lib#10362 include editorName when logging an editorial decision #10628

Open
wants to merge 1 commit into
base: stable-3_4_0
Choose a base branch
from
Open

pkp/pkp-lib#10362 include editorName when logging an editorial decision #10628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion classes/controllers/grid/users/reviewer/PKPReviewerGridHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ public function reviewRead($args, $request)
'message' => 'log.review.reviewConfirmed',
'isTranslated' => false,
'dateLogged' => Core::getCurrentDate(),
'editorName' => $user->getFullName(),
'userName' => $user->getFullName(),
'submissionId' => $reviewAssignment->getSubmissionId(),
'round' => $reviewAssignment->getRound()
]);
Expand Down
7 changes: 4 additions & 3 deletions classes/decision/Repository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
/**
* @file classes/decision/Repository.php
*
* Copyright (c) 2014-2022 Simon Fraser University
* Copyright (c) 2000-2022 John Willinsky
* Copyright (c) 2014-2024 Simon Fraser University
* Copyright (c) 2000-2024 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
*
* @class Repository
Expand Down Expand Up @@ -237,6 +237,7 @@ public function add(Decision $decision): int
? PKPSubmissionEventLogEntry::SUBMISSION_LOG_EDITOR_RECOMMENDATION
: PKPSubmissionEventLogEntry::SUBMISSION_LOG_EDITOR_DECISION,
'userId' => Validation::loggedInAs() ?? $this->request->getUser()?->getId(),
'editorName' => $editor->getFullName(),
'message' => $decisionType->getLog(),
'isTranslated' => false,
'dateLogged' => Core::getCurrentDate()
Expand Down Expand Up @@ -378,7 +379,7 @@ abstract public function getDecisionTypes(): Collection;
abstract public function getDeclineDecisionTypes(): array;

/**
* Get a list of the decision types that a recommending user is
* Get a list of the decision types that a recommending user is
* allowed to make given a submission stage id.
*
* @return DecisionType[]
Expand Down